SCANJLIB-169 Omit the stack trace of connection errors with SonarQube

[javier-garcia-sonarsource]

SCANJLIB-169

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
1 Accepted issue

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[henryju]

Have you manually tested the change? I don't see how this would prevent to log a stacktrace.
What we usually do (for example in the Scanner Engine) is to create a special type of exception (see MessageException). This exception will be caught at the higher possible level, and then log will be:

• only log the exception message in INFO
• if the debug level is enabled, log message + stacktrace

[javier-garcia-sonarsource]

Have you manually tested the change? I don't see how this would prevent to log a stacktrace. What we usually do (for example in the Scanner Engine) is to create a special type of exception (see MessageException). This exception will be caught at the higher possible level, and then log will be:

• only log the exception message in INFO
• if the debug level is enabled, log message + stacktrace

Hi @henryju , do you mean this? https://github.com/SonarSource/sonar-scanner-engine/blob/master/sonarcloud/sonar-scanner-engine/src/main/java/org/sonar/scanner/bootstrap/ScannerMain.java#L76

[henryju]

Have you manually tested the change? I don't see how this would prevent to log a stacktrace. What we usually do (for example in the Scanner Engine) is to create a special type of exception (see MessageException). This exception will be caught at the higher possible level, and then log will be:

• only log the exception message in INFO
• if the debug level is enabled, log message + stacktrace

Hi @henryju , do you mean this? https://github.com/SonarSource/sonar-scanner-engine/blob/master/sonarcloud/sonar-scanner-engine/src/main/java/org/sonar/scanner/bootstrap/ScannerMain.java#L76

yes, that is what I was referring to. I would suggest to take inspiration from that.

[javier-garcia-sonarsource]

Closing this PR because the changes needed to fix this issue are more complex than expected. I will add my findings on the ticket description