-
Notifications
You must be signed in to change notification settings - Fork 313
feat: add remaining PFC checks and lightweight PR builds BED-6802 #2239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
7a9bee2
feat: remaining PFC checks encoded as workflow
superlinkx 465cc74
fix: try again
superlinkx 26e8715
fix: missing license check and handle no tags
superlinkx 12dd647
fix: fetch depth 2 to allow for diff-index to work
superlinkx f74811a
fix: better diff handling
superlinkx 46ca554
fix: formatting
superlinkx fc51446
fix: show all the problems
superlinkx 3ca3327
chore: try to understand why things are off the rails
superlinkx 73cee9a
fix: remove file that regenerates only on pipelines
superlinkx 6a7c190
fix: ignore changes to file, rather than ignoring file for license check
superlinkx a800000
fix: reset mockServiceWorker.js
superlinkx 6854222
chore: promote workflow to actual triggers
superlinkx a5c1506
chore: fixups and new PR build workflow
superlinkx 6449ed8
chore: CR feedback
superlinkx cafe4de
IMPORTANT: revert this commit, only used for testing
superlinkx 8ad3573
fix: incorrect action config
superlinkx c069776
Revert "IMPORTANT: revert this commit, only used for testing"
superlinkx 3e1275f
chore: CR fixes
superlinkx aaab1df
chore: cr fixes
superlinkx ee4bbd7
chore+wip: PR feedback
superlinkx d7d4cc3
chore: better slow go workflow because it's breaking in main
superlinkx 3a6cd64
chore: remove parallel because it tends to cause sporadic DB errors
superlinkx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| # Copyright 2026 Specter Ops, Inc. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| name: Code Generation Check | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| - "stage/**" | ||
| types: | ||
| - opened | ||
| - synchronize | ||
|
|
||
| jobs: | ||
| code-generation-check: | ||
| name: Code Generation Check | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout source code for this repository | ||
| uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # ratchet:actions/checkout@v5 | ||
|
|
||
| - name: Install Go | ||
| uses: actions/setup-go@40f1582b2485089dde7abd97c1529aa768e1baff # ratchet:actions/setup-go@v5 | ||
| with: | ||
| go-version-file: go.mod | ||
| cache: true | ||
|
superlinkx marked this conversation as resolved.
|
||
| check-latest: true | ||
|
|
||
| - name: Install Node | ||
| uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # ratchet:actions/setup-node@v4 | ||
| with: | ||
| node-version: 22 | ||
|
|
||
| - name: Enable Corepack | ||
| run: | | ||
| corepack enable | ||
|
|
||
| - name: Run stbernard deps | ||
| run: | | ||
| go tool stbernard deps | ||
|
|
||
| - name: Run stbernard modsync | ||
| run: | | ||
| go tool stbernard modsync | ||
|
|
||
| - name: Run stbernard generate | ||
| run: | | ||
| go tool stbernard generate | ||
|
|
||
| - name: Run stbernard license | ||
| run: | | ||
| go tool stbernard license | ||
|
|
||
| - name: Check for uncommitted changes | ||
| id: show | ||
| run: | | ||
| go tool stbernard show -no-version | ||
|
|
||
| - name: Fail with helpful message | ||
| if: failure() && steps.show.outcome == 'failure' | ||
| run: | | ||
| echo "::error::Code generation check failed!" | ||
| echo "" | ||
| echo "==========================================" | ||
| echo " CODE GENERATION CHECK FAILED" | ||
| echo "==========================================" | ||
| echo "" | ||
| echo "This PR has uncommitted generated code or dependency changes." | ||
| echo "" | ||
| echo "Please run the following command locally and commit the changes:" | ||
| echo "" | ||
| echo " just prepare-for-codereview" | ||
| echo "" | ||
| echo "Then push the updated changes to this PR." | ||
| echo "" | ||
| echo "==========================================" | ||
| exit 1 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.