Conversation
mistahj67
added
the
api
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
| if nodeKind, ok := displayKinds[kind]; ok { | ||
| resp.NodeKinds[kind.String()] = nodeKind | ||
| // Asset group tags are node kinds as well as meta kinds, they do not have icons | ||
| } else if strings.HasPrefix(kind.String(), model.AssetGroupTagKindPrefix) || kind.Is(graph.StringKind("Meta"), graph.StringKind("MetaDetail"), graph.StringKind("MigrationData")) { |
There was a problem hiding this comment.
suggestion (non-blocking): it might be nice to consolidate all of these checks into a method on the kind that we could call
There was a problem hiding this comment.
I'm hesitant to codify this at such a basal type struct as "kind" as it is used quite extensively in this codebase
2 participants
Description
Describe your changes in detail
Extends
/kindswithnode_kindsandedge_kindsmap to provide icon / display name information to be used by the UIMotivation and Context
Resolves BED-7925
Why is this change required? What problem does it solve?
How Has This Been Tested?
Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.
Screenshots (optional):
Types of changes
Checklist: