Replace JAMFHound repo and fix mermaid diagram renders#229
Replace JAMFHound repo and fix mermaid diagram renders#229so-lcain wants to merge 3 commits intoSpecterOps:mainfrom
Conversation
…ks, and escape '@' in mermaid diagrams
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughDocumentation-only updates: standardized MDX frontmatter, escaped Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/opengraph/extensions/jamfhound/reference/edges/jamf_azmatchedemail.mdx`:
- Around line 19-36: Remove the unnecessary backslash escapes before the @
characters in the Mermaid node labels for the AzureAD_User nodes (e.g., B, D, F)
in the jamf_azmatchedemail.mdx Mermaid graph; locate the node label strings like
B("AzureAD_User\njohn.admin\@contoso.com") and remove the backslash so the
labels read john.admin@contoso.com (keep the double quotes and newline
formatting intact) for all affected nodes.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4d698740-b42a-40b8-a793-de7317391d83
📒 Files selected for processing (5)
docs/opengraph/extensions/jamfhound/reference/edges/jamf_azmatchedemail.mdxdocs/opengraph/extensions/jamfhound/reference/edges/jamf_matchedemail.mdxdocs/opengraph/extensions/jamfhound/reference/privilege-zone-rules.mdxdocs/opengraph/extensions/jamfhound/reference/queries.mdxdocs/opengraph/extensions/jamfhound/reference/schema.mdx
docs/opengraph/extensions/jamfhound/reference/edges/jamf_azmatchedemail.mdx
Show resolved
Hide resolved
| ``` | ||
| --- | ||
| title: 'jamf_AZMatchedEmail' | ||
| description: 'Represents a cross-platform identity correlation where the JAMF principal''s email attribute matches an Azure AD account''s email.' |
There was a problem hiding this comment.
Are the double apostrophes in "principal" and "account" expected?
| ``` | ||
| --- | ||
| title: 'jamf_MatchedEmail' | ||
| description: 'Represents an identity correlation where the JAMF computer user''s email attribute matches the JAMF account''s email.' |
There was a problem hiding this comment.
Are the double apostrophes in "user" and "account" expected?
3 participants
The current documentation for the JamfHound extension refers to an internal SpecterOps repository "JAMFHound_Internal". These changes update references to point to SpecterOps/JamfHound that is publicly accessible. Also, the mermaid diagrams for two JamfHound edges which included emails have an error 'Unsupported markdown: link' when rendered on the official docs site. The '@' characters in the emails have been escaped as an attempt to fix this.
Summary by CodeRabbit