fix: URL-encode special characters in credentials for XMLRPC URI in nipap-cli#1449
Open
fredsod wants to merge 1 commit intoSpriteLink:masterfrom
Open
fix: URL-encode special characters in credentials for XMLRPC URI in nipap-cli#1449fredsod wants to merge 1 commit intoSpriteLink:masterfrom
fredsod wants to merge 1 commit intoSpriteLink:masterfrom
Conversation
houndci-bot
reviewed
Mar 9, 2026
…ipap-cli. Passwords (and usernames) containing special characters such as '/', '@' or ':' would break the XMLRPC URI used by nipap-cli because urllib.parse.quote() defaults to safe='/', leaving '/' unencoded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passwords (and usernames) containing special characters such as '/', '@' or ':' would break the XMLRPC URI used by nipap-cli because urllib.parse.quote() defaults to safe='/', leaving '/' unencoded.