chore(stacks-svelte): adjust peer deps #2128
Merged
+29
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a0f182a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for stacks-svelte ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjust 2 things in the
@stackoverflow/stacks-sveltepackage.json:onlyUpdatePeerDependentsWhenOutOfRangeexperimental option of changeset to true so that the@stackoverflow/stackspeer dependency version is not overridden every time a new version is published. Specifically we need to keep also v2 as a peer dependency because in projects like our Core codebase stacks v2 and v3 will coexist together for a while and we don't want the npm algorithm to prevent installation (see this Core PR for context). We already added v2 as a peer dependency a while back but changeset overrode it when it upgraded the stacks library (context). The new flag should prevent that from happening in the future.@stackoverflow/stacks-utilspackage from being a peer dependency to a regular dependency (so that consumer don't need to install it manually themselves and we retain more control over breaking changes within the package that affects stacks svelte). It is also consistent with what we do for the dependency on@stackoverflow/stacks-icons.