Skip to content

Pants: Misc pants-plugins/uses_services improvements #5898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cognifloyd merged 3 commits into from
Feb 14, 2023
Merged

Pants: Misc pants-plugins/uses_services improvements #5898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ddff02
shorten timeout for uses_services/mongo tests
cognifloyd Feb 10, 2023
78c383f
register rules for pants-plugins/uses_services rabbitmq and redis
cognifloyd Feb 10, 2023
677e7b6
update changelog entry
cognifloyd Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Added
to pants' use of PEX lockfiles. This is not a user-facing addition.
#5778 #5789 #5817 #5795 #5830 #5833 #5834 #5841 #5840 #5838 #5842 #5837 #5849 #5850
#5846 #5853 #5848 #5847 #5858 #5857 #5860 #5868 #5871 #5864 #5874 #5884 #5893 #5891
#5890
#5890 #5898
Contributed by @cognifloyd

* Added a joint index to solve the problem of slow mongo queries for scheduled executions. #5805
Expand Down
1 change: 1 addition & 0 deletions pants-plugins/uses_services/mongo_rules_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ def test_mongo_not_running(rule_runner: RuleRunner, mock_platform: Platform) ->
request = UsesMongoRequest(
db_host="127.100.20.7",
db_port=10, # unassigned port, unlikely to be used
db_connection_timeout=10, # ms # very short as it should fail anyway
)

with pytest.raises(ExecutionError) as exception_info:
Expand Down
4 changes: 3 additions & 1 deletion pants-plugins/uses_services/register.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
PythonTestsGeneratorTarget,
)

from uses_services import mongo_rules, platform_rules
from uses_services import mongo_rules, platform_rules, rabbitmq_rules, redis_rules
from uses_services.target_types import UsesServicesField


Expand All @@ -26,4 +26,6 @@ def rules():
PythonTestTarget.register_plugin_field(UsesServicesField),
*platform_rules.rules(),
*mongo_rules.rules(),
*rabbitmq_rules.rules(),
*redis_rules.rules(),
]