Release: Upstream PR Integration #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in [1] some SMART errors are transient and should not be treated as permanent. This commit adds support for a configurable list of ATA SMART attribute IDs, failures of which will be treated as transient. Drive health history is still recorded and notifications are sent, but the device itself is not marked as failed. Fixes AnalogJ#374. [1] AnalogJ#374
(not tested yet)
Conflicts: webapp/backend/pkg/database/scrutiny_repository_migrations.go
This commit makes two modification to smart temperature logging: - Even if ata_sct_temperature_history is present, log current time. - Forcefully align each ata_sct_temperature_history data point according to logging interval reported in SMART. This prevents duplicated datapoints. Fixes 824
…fetching recent entries - Updated the aggregation logic in `aggregateSmartAttributesQuery` to utilize `limit()` for retrieving the newest entries after sorting, ensuring correct data retrieval. - Adjusted subquery construction to improve clarity and maintainability. - Enhanced comments for better understanding of the changes made. (cherry picked from commit c1f70ff)
- Added configuration options for enabling Prometheus metrics in `example.scrutiny.yaml` and `config.go`. - Introduced a new `metrics` package to handle metrics collection and registration. - Created a `ScrutinyCollector` to gather device metrics and expose them via a `/metrics` endpoint. - Updated the web server to conditionally register the metrics endpoint based on configuration. - Implemented caching for device details to optimize metrics collection. - Added tests for utility functions related to metrics sanitization and parsing. This commit enhances the monitoring capabilities of Scrutiny by integrating Prometheus metrics support.
Owner
Author
Release Integration (2025-11-30)Batch integration of upstream contributions into Starosdev/scrutiny. Changes Made
Thanks to all upstream contributors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This release integrates 9 upstream PRs from AnalogJ/scrutiny that have been tested and verified.
Features
/api/metrics) - PR Implement Prometheus metrics support in Scrutiny AnalogJ/scrutiny#830Fixes
ata_sct_temperature_historyAnalogJ/scrutiny#825Testing
All features manually tested on develop branch with 15+ drives:
Upstream PRs Integrated
ata_sct_temperature_historyAnalogJ/scrutiny#825