fix(notify): try to unmarshal notify.urls as JSON array #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When notify.urls is configured as a JSON array in the config file, Viper's GetStringSlice may not parse it correctly. This fix attempts to unmarshal the raw string as JSON first, falling back to the original behavior if that fails.
Starosdev
force-pushed
the
fix/upstream-pr-750-notify-url-unmarshal
branch
from
e1ecc82 to
9109fb5
Compare
Starosdev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When
notify.urlsis configured as a JSON array in the config file, Viper'sGetStringSlicemay not parse it correctly. This fix attempts to unmarshal the raw string as JSON first, falling back to the original behavior if that fails.Origin
notify.urland use it when needed AnalogJ/scrutiny#750Changes
notify.urlsconfigurationGetStringSliceif JSON parsing failsTest Plan