Login Credentials: Atmosphere branding + show handle with DID (v0.4.3)#108
Merged
Conversation
The "Login Credentials" section on the profile page still showed, for an atproto credential, the old Bluesky butterfly, the bare label "Atproto", and only the DID. Fixes (in both the server and client renderers, which must match — the client re-renders over the SSR output): - Icon: the Atmosphere "union" mark (a stale butterfly remained in profile.html's client-side getProviderIcon; the SSR copy was already updated). - Label: "Atmosphere / ATproto" instead of the capitalized provider key. - Identifier: show the handle with the DID in parens, e.g. "alice.bsky.social (did:plc:...)", falling back to the bare DID when no handle was stored. To support that, persist the atproto handle at login: add UserProfile.handle, set it from the resolved identity in exchange(), and surface it from UserDO.listCredentials(). Existing credentials (logged in before this change) have no stored handle and show the DID alone until next login. Tests: assert the handle is persisted, and that the SSR'd profile page shows the branded label + "handle (did)" and never the butterfly mark. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
startup-api | b363f76 | Jun 29 2026, 04:16 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Login Credentials section — Atmosphere branding + handle
On the profile page's Login Credentials section, an atproto credential still rendered the old Bluesky butterfly, the bare label "Atproto", and only the DID (no handle).
Fixes (server + client renderers — the client re-renders over the SSR output, so both must match)
profile.html's client-sidegetProviderIcon; the SSR copy was already updated in 0.4.1.alice.bsky.social (did:plc:…), falling back to the bare DID when no handle is stored.Supporting change
The handle wasn't persisted. Added
UserProfile.handle, set it from the resolved identity inexchange(), and surfaced it fromUserDO.listCredentials().Tests
Atmosphere / ATproto+tester.bsky.social (did:plc:abc123)and never the butterfly path.profile.htmlfunctions in isolation (correct label/identifier/icon + graceful no-handle fallback).tsc+eslintclean; full suite 129/129. Bumps to 0.4.3.🤖 Generated with Claude Code