fix(migration): add missing closing brace in migrateSkills function#147
fix(migration): add missing closing brace in migrateSkills function#147Steffen025 merged 1 commit intomainfrom
Conversation
The if (skillFiles.includes('SKILL.md')) block at line 207 was never
closed. The existing closing brace was incorrectly labeled as 'Close
SKILL.md check' but actually closed the if (dryRun)/else block. This
caused a TypeScript syntax error that prevented CodeQL from completing
its JavaScript/TypeScript analysis scan.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA structural reorganization of brace closures and comments within the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Summary
Tools/migration-v2-to-v3.tsthat blocked CodeQL JavaScript/TypeScript scanif (skillFiles.includes('SKILL.md'))block at L207 was never closed — the}at L249 closed the innerif (dryRun)/elseblock but the SKILL.md check remained open}between L249 and L250Root Cause
Mixed indentation + misleading comment masked the brace mismatch. Brace count across
migrateSkills()was off by one (net: 1 instead of 0).Verification
bun run Tools/migration-v2-to-v3.ts --dry-run --forcecompletes fully without parse errors.Summary by CodeRabbit