Skip to content

Use intermediate vars to decrease minified size #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timtucker wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use intermediate vars to decrease minified size #151

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bf12d9
Use intermediate vars to decrease minified size
timtucker Mar 20, 2013
df1f520
Use (a !== b) instead of !(a === b)
timtucker Mar 20, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions knockout.mapping.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,11 +743,15 @@
if (ko.utils.arrayIndexOf(options.include, indexer) === -1) {
// The mapped properties object contains all the properties that were part of the original object.
// If a property does not exist, and it is not because it is part of an array (e.g. "myProp[3]"), then it should not be unmapped.
if (unwrappedRootObject[mappingProperty]
&& unwrappedRootObject[mappingProperty].mappedProperties && !unwrappedRootObject[mappingProperty].mappedProperties[indexer]
&& unwrappedRootObject[mappingProperty].copiedProperties && !unwrappedRootObject[mappingProperty].copiedProperties[indexer]
&& !(exports.getType(unwrappedRootObject) === "array")) {
return;
var unwrappedRootMappingProperty = unwrappedRootObject[mappingProperty];
if (unwrappedRootMappingProperty) {
var mappedProperties = unwrappedRootMappingProperty.mappedProperties;
if (mappedProperties && !mappedProperties[indexer]) {
var copiedProperties = unwrappedRootMappingProperty.copiedProperties;
if (copiedProperties && !copiedProperties[indexer] && (exports.getType(unwrappedRootObject) !== "array")) {
return;
}
}
}
}
}
Expand Down