Repository navigation
fix(security): The updater must re-verify the checksum of the downloaded artifact at install time so a same-uid swap after the confirmation prompt cannot replace the approved bytes. - #473
Open
github-actions[bot] wants to merge 3 commits into
Conversation
Signed-off-by: Test Writer Agent <test-writer@security-remediate.invalid>
Signed-off-by: Test Writer Agent <test-writer@security-remediate.invalid>
…ded artifact at install time so a same-uid swap after the confirmation prompt cannot replace the approved bytes. Signed-off-by: Fix Writer Agent <fix-writer@security-remediate.invalid>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: Refs #321
What
Plannow carriesWantChecksum, the SHA-256 digest verified at download time.Applyre-verifies the artifact bytes at install time and aborts on mismatch, for both the package-manager and self-replace paths.Applyalso refuses any plan that carries no verified digest.Why
How
Checkrecords the digest that passed verification inPlan.WantChecksum(internal/updater/updater.go).Verification
go build ./...,go vet ./...,gofmt -l ., andstaticcheck ./...pass.internal/updater/download_tamper_security_test.gopass, along with the full updater test suite (go test ./internal/updater/...).Follow-up