-
-
Notifications
You must be signed in to change notification settings - Fork 426
feat: update notification #1166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: update notification #1166
Conversation
|
I am not sure about the current logic for whether it is outdated or not. Alternatively latest versions with suffixes could just generally be ignored. This would mean that if |
|
Is there a reason to not use semver for comparing the versions? It'd likely be a lot more reliable and consistent than creating a custom implementation for essentially the same thing. As for versions with suffixes, I think having them be ignored would probably be best. Recommending non-release versions to normal users probably isn't a good idea, and most users who do use non-release versions likely keep an eye on version releases already. |
|
I have replaced the regex parsing with the semver depency as suggested and have also cleaned up the comparison logic there to be more readable. Also, the update notification modal now links directly to the page for the latest release (for people who aren't familiar with github). |
Summary
Displays a notification to the user when a newer tagstudio version is available.
Tasks Completed