Skip to content

Conversation

@Computerdores
Copy link
Collaborator

Summary

Displays a notification to the user when a newer tagstudio version is available.

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@Computerdores
Copy link
Collaborator Author

I am not sure about the current logic for whether it is outdated or not.
Currently if any newer version with a suffix (e.g. 1.2.3-pr1) is available then the notification is displayed (and the comparison is currently broken if both have a suffix).

Alternatively latest versions with suffixes could just generally be ignored. This would mean that if 1.2.3-pr1 is the latest release, 1.2.2 is the latest full release and the user has 1.2.1 installed then no notification would displayed (I think; if RCs are ignored by the API endpoint than RCs don't matter anyways).

@Computerdores Computerdores moved this to 🏓 Ready for Review in TagStudio Development Oct 13, 2025
@Computerdores Computerdores added Type: UI/UX User interface and/or user experience Status: Review Needed A review of this is needed labels Oct 13, 2025
@TrigamDev
Copy link
Contributor

Is there a reason to not use semver for comparing the versions? It'd likely be a lot more reliable and consistent than creating a custom implementation for essentially the same thing.

As for versions with suffixes, I think having them be ignored would probably be best. Recommending non-release versions to normal users probably isn't a good idea, and most users who do use non-release versions likely keep an eye on version releases already.

@Computerdores Computerdores moved this from 🏓 Ready for Review to 🚧 In progress in TagStudio Development Nov 22, 2025
@Computerdores Computerdores removed the Status: Review Needed A review of this is needed label Nov 22, 2025
@Computerdores Computerdores moved this from 🚧 In progress to 🏓 Ready for Review in TagStudio Development Nov 22, 2025
@Computerdores Computerdores added the Status: Review Needed A review of this is needed label Nov 22, 2025
@Computerdores
Copy link
Collaborator Author

I have replaced the regex parsing with the semver depency as suggested and have also cleaned up the comparison logic there to be more readable.

Also, the update notification modal now links directly to the page for the latest release (for people who aren't familiar with github).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Review Needed A review of this is needed Type: UI/UX User interface and/or user experience

Projects

Status: 🏓 Ready for Review

Development

Successfully merging this pull request may close these issues.

2 participants