Skip to content

fix: prevent deadlock when wanted mnemonics conflict #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: prevent deadlock when wanted mnemonics conflict #1200

wants to merge 2 commits into from

Conversation

@Computerdores
Copy link
Collaborator

@Computerdores Computerdores commented Nov 12, 2025 •
edited
Loading

Summary

Closes #1184

Adds a warning if an invalid mnemonic is encountered (more than one & marker or same & marker as another entry in the same menu) and fixes existing translations with invalid mnemonics.

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@Computerdores Computerdores marked this pull request as ready for review November 12, 2025 13:33
@Computerdores Computerdores moved this to 🏓 Ready for Review in TagStudio Development Nov 12, 2025
@Computerdores Computerdores added Type: Bug Something isn't working as intended Type: Translations Modifies translation keys or translation capabilities. labels Nov 12, 2025
@CyanVoxel CyanVoxel added this to the Alpha v9.5.x milestone Nov 14, 2025
@CyanVoxel CyanVoxel added the Status: Review Needed A review of this is needed label Nov 14, 2025
@CyanVoxel CyanVoxel self-assigned this Nov 14, 2025
@CyanVoxel CyanVoxel added Status: Blocked This issue or pull request is awaiting the outcome of another issue or pull request Note: Sync Weblate Before Pulling Indicates that the Weblate translations repository needs to be up to date before pulling this code. and removed Status: Blocked This issue or pull request is awaiting the outcome of another issue or pull request labels Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@CyanVoxel CyanVoxel

Labels

Note: Sync Weblate Before Pulling Indicates that the Weblate translations repository needs to be up to date before pulling this code. Status: Review Needed A review of this is needed Type: Bug Something isn't working as intended Type: Translations Modifies translation keys or translation capabilities.

Projects

TagStudio Development
Status: 🏓 Ready for Review

Milestone

Alpha v9.5.x

Development

Successfully merging this pull request may close these issues.

[Bug]: Portable launch goes background (No UI presented) if language set to Russian

2 participants

@Computerdores @CyanVoxel