Redesign the About page around Apple's interface guidelines - #12
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 74b483bbbc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
An abandoned gesture could leave the track parked between slides: pointerdown stops the loop and clears velocity before horizontal intent is known, but a tap inside the 10px hysteresis returns early from endDrag, and a vertical move clears activePointer so endDrag never runs at all. Both paths now resume the pending motion. Reduced motion also still slid a full viewport width on every arrow, dot, key and drag release — only faster, at a 150ms response. It now lands on the target slide without traversing. Dragging stays 1:1, since that is the finger rather than an animation. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuilds
docs/index.html(the About / landing page) following Apple's HIG-derived design and motion rules.Design
-0.035em→ body0→ small caps+0.09em), leading that moves inversely to size, a fluidclamp()scale with spacing inremso the layout scales with the user's text size, andfont-feature-settings: "palt"for Japanese headings.backdrop-filterlayer that content scrolls under, with a scroll edge effect (a gradient that fades in once content is beneath it) instead of a permanent 1px divider. Shadow weight now scales with surface size.prefers-color-scheme;releases.htmlfollows through the shared variables.Motion (
docs/interactions.js, no dependencies)A spring parameterised the Apple way (damping ratio + response in seconds) drives a draggable promo carousel:
setPointerCaptureand grab-offset preserved(v/1000)·d/(1−d), then handed to the spring as initial velocityPress feedback fires on
pointerdownrather thanclick.Accessibility
prefers-reduced-motion,prefers-reduced-transparencyandprefers-contrast: moreare each handled. Without JavaScript nothing is hidden and the carousel falls back to the original stacked strip. A skip link and in-page nav links were added; the four new strings are translated in all four languages.Two fixes found along the way
body { overflow-x: hidden }made<body>the scroll container, so the nav scrolled away. Clipping now lives on<html>only. Verified no horizontal overflow from 320px to 1920px.Verification
Chrome, light/dark/mobile, all four languages (no unresolved i18n keys), JS-disabled and reduced-motion paths, carousel gestures (flick, slow drag, edge rubber-band, mid-flight interrupt, vertical pass-through), and no horizontal overflow at eight widths.
🤖 Generated with Claude Code