Add widget background style (solid / clear Liquid Glass) and tinted support - #3
Merged
Merged
Conversation
…upport Let the user choose the widget background in Settings: - Solid: the existing opaque .fill.tertiary (light/dark aware). - Clear (Liquid Glass): translucent glassEffect background, offered only on macOS 26+ where the API exists; the widget falls back to solid on older systems. The choice rides the App Group snapshot (WidgetBackgroundStyle) alongside the existing language/notation, and republishes on change. Also optimize the widget for tinted (accented) rendering mode: brand icons, the progress-bar fill, the headline percentage, and the large-widget chart line are marked .widgetAccentable() so they take the accent colour while labels stay in the dimmed group. containerBackground is left removable, so the OS-level light/dark/tinted/clear appearances all work. Adds sample-data SwiftUI previews (plain views, since macOS cannot preview a widget extension in the canvas). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
ウィジェットの背景色を設定で選べるようにし、macOS 26 の Liquid Glass / tinted 外観に対応します。
変更内容
アプリ内の背景スタイル選択
.fill.tertiary（light/dark 自動追従）glassEffect背景。API が存在する macOS 26+ でのみ設定に表示し、それ以前は自動的に solid にフォールバックWidgetBackgroundStyle）で widget に渡し、変更時に再発行OS 外観への対応
.widgetAccentable()でアクセントグループに配置。ラベル類は減光側に残して階層を維持containerBackgroundは removable のままなので、OS 側の light/dark/tinted/clear がすべて機能その他
検証
swift test: 111 件パス（スナップショットの後方互換デコード含む）xcodebuild ... CODE_SIGNING_ALLOWED=NO: BUILD SUCCEEDED備考
本 PR には app icon 関連（
project.yml/AppIcon.icon）は含めていません。🤖 Generated with Claude Code