Conversation
ZacLou
force-pushed
the
feat/schema-validation-bulk-1196
branch
from
September 6, 2026 10:52
ef26bf3 to
f4ad98d
Compare
…t#1196) - Reuse the existing create/update Zod schemas for bulk items - Enforce field bounds, strip unknown fields, and return per-field errors - Require a contract identifier for update and delete items - Map update items through the typed boundary mapper - Add schema and HTTP integration tests
ZacLou
force-pushed
the
feat/schema-validation-bulk-1196
branch
from
September 6, 2026 10:56
f4ad98d to
8140284
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1196.
This moves validation for the contract bulk API to the request boundary, while preserving the endpoint's existing partial-success behavior.
Changes
bulkContractItemSchemaas a Zod discriminated union overaction.createreuses the existing create-contract schema.updatereuses the existing update-contract schema and accepts eithercontractIdorid.deleterequiresversionand accepts eithercontractIdorid.superRefinerule requiring an identifier forupdateanddelete.safeParse.validation_errorwith field-leveldetails.Verification