Move identifier quoting to Electric client #1042
Closed
+259
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove quoteIdentifier function from sql-compiler.ts so that Electric's encodeWhereClause can see the original unquoted identifiers and properly apply columnMapper transformations (e.g., camelCase → snake_case) before quoting. This fixes an issue where columnMapper encoding was not applied to subset queries because double-quoted identifiers were preserved by Electric's encodeWhereClause per PostgreSQL semantics. Fixes #1032
|
More templates
@tanstack/angular-db
@tanstack/db
@tanstack/db-ivm
@tanstack/electric-db-collection
@tanstack/offline-transactions
@tanstack/powersync-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/rxdb-db-collection
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
Contributor
|
Size Change: 0 B Total Size: 88.5 kB ℹ️ View Unchanged
|
Contributor
|
Size Change: 0 B Total Size: 3.35 kB ℹ️ View Unchanged
|
samwillis
previously approved these changes
Dec 18, 2025
samwillis
requested changes
Dec 18, 2025
…ent" This reverts commit a9a0e65.
KyleAMathews
force-pushed
the
claude/move-identifier-quoting-6mWW7
branch
from
200a3c7 to
00f7656
Compare
Add whereExpr and orderByExpr fields to compileSQL output alongside the
existing string-compiled where/orderBy fields. This enables Electric to:
1. Receive original column names (e.g., 'userId' not '"userId"')
2. Apply columnMapper transformations (e.g., userId → user_id)
3. Handle quoting correctly after transformation
The structured format uses a simple expression tree:
- { type: 'ref', column: string } - column reference
- { type: 'val', paramIndex: number } - parameter placeholder
- { type: 'func', name: string, args: [...] } - operator/function
Electric should prefer whereExpr/orderByExpr when present, falling back
to where/orderBy strings for backwards compatibility with older clients.
Related to #1032
Collaborator
Author
|
closing in favor of electric-sql/electric#3629 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove quoteIdentifier function from sql-compiler.ts so that Electric's encodeWhereClause can see the original unquoted identifiers and properly apply columnMapper transformations (e.g., camelCase → snake_case) before quoting.
This fixes an issue where columnMapper encoding was not applied to subset queries because double-quoted identifiers were preserved by Electric's encodeWhereClause per PostgreSQL semantics.
Fixes #1032
🎯 Changes
✅ Checklist
pnpm test:pr.🚀 Release Impact