-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix(router-generator): fix layout/index conflict in virtual physical(… #6252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughAdds layout-aware fallback path handling in route node generation and introduces a comprehensive test case for the virtual-physical-layout-and-index scenario, enabling both Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (8)
🧰 Additional context used📓 Path-based instructions (2)**/*.{ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{js,ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
🧠 Learnings (9)📓 Common learnings📚 Learning: 2025-12-17T02:17:55.086ZApplied to files:
📚 Learning: 2025-10-08T08:11:47.088ZApplied to files:
📚 Learning: 2025-10-01T18:31:35.420ZApplied to files:
📚 Learning: 2025-12-21T12:52:35.231ZApplied to files:
📚 Learning: 2025-12-06T15:03:07.223ZApplied to files:
📚 Learning: 2025-12-06T15:03:07.223ZApplied to files:
📚 Learning: 2025-11-02T16:16:24.898ZApplied to files:
📚 Learning: 2025-10-01T18:30:26.591ZApplied to files:
🧬 Code graph analysis (3)packages/router-generator/tests/generator/virtual-physical-layout-and-index/routes/index.tsx (3)
packages/router-generator/tests/generator/virtual-physical-layout-and-index/routes/feature/route.tsx (3)
packages/router-generator/tests/generator/virtual-physical-layout-and-index/routes/__root.tsx (3)
🪛 ast-grep (0.40.3)packages/router-generator/src/filesystem/physical/getRouteNodes.ts[warning] 252-252: Regular expression constructed from variable input detected. This can lead to Regular Expression Denial of Service (ReDoS) attacks if the variable contains malicious patterns. Use libraries like 'recheck' to validate regex safety or use static patterns. (regexp-from-variable) [warning] 257-257: Regular expression constructed from variable input detected. This can lead to Regular Expression Denial of Service (ReDoS) attacks if the variable contains malicious patterns. Use libraries like 'recheck' to validate regex safety or use static patterns. (regexp-from-variable) ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (8)
Comment |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx affected --targets=test:eslint,test:unit,tes... |
❌ Failed | 16m 1s | View ↗ |
nx run-many --target=build --exclude=examples/*... |
✅ Succeeded | 34s | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-12-30 01:56:46 UTC

…) routes
fixes #5421
Summary by CodeRabbit
Bug Fixes
Tests
✏️ Tip: You can customize this high-level summary in your review settings.