Skip to content

Field Type Registry: Share custom types across instances #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-jaussaud merged 5 commits into from
May 27, 2026
Merged

Field Type Registry: Share custom types across instances #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1166e99
Field Type Registry: Share custom types across instances
nicolas-jaussaud May 19, 2026
deea0b1
Merge branch 'main' into fix/field-registry-shared-types
nicolas-jaussaud May 26, 2026
dd8c84a
Field Type Registry: Revert shared custom types and give possibility …
nicolas-jaussaud May 26, 2026
6332792
Tests: Field Type Registry - Update tests according to last changes
nicolas-jaussaud May 26, 2026
19c11c4
Field Type Registry: Remove uneeded condition in constructor (added f…
nicolas-jaussaud May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/DataView/DataView.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ class DataView {
* - ui: array - WordPress admin UI configuration
* - capability: string - required capability (default: 'manage_options')
*/
public function __construct( array $config ) {
$this->registry = new FieldTypeRegistry();
public function __construct( array $config, ?FieldTypeRegistry $registry = null ) {
$this->registry = $registry ?? new FieldTypeRegistry();
$this->label_generator = new LabelGenerator();
$this->schema_generator = new SchemaGenerator( $this->registry );

Expand Down
72 changes: 72 additions & 0 deletions tests/phpunit/data-view.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,78 @@ public function test_field_type_registry_has_default_types(): void {
$this->assertTrue( $registry->has_type( 'datetime' ) );
}

public function test_field_type_registry_has_custom_types(): void {
$registry_1 = new FieldTypeRegistry();
$registry_2 = new FieldTypeRegistry();

$registry_1->register_type( 'custom_type_1', [
'dataset' => DataSet::TYPE_STRING,
'sanitizer' => fn( $value ) => ( $value ),
'schema' => [],
'input' => 'hidden',
] );

$registry_2->register_type( 'custom_type_2', [
'dataset' => DataSet::TYPE_INTEGER,
'sanitizer' => fn( $value ) => ( $value ),
'schema' => [],
'input' => 'hidden',
] );

$this->assertTrue( $registry_1->has_type( 'custom_type_1' ) );
$this->assertTrue( $registry_2->has_type( 'custom_type_2' ) );

$this->assertFalse( $registry_1->has_type( 'custom_type_2' ) );
$this->assertFalse( $registry_2->has_type( 'custom_type_1' ) );

foreach( [
$registry_1,
$registry_2
] as $registry ) {
// Check defaults are not erased by custom
$this->assertTrue( $registry->has_type( 'string' ) );
$this->assertTrue( $registry->has_type( 'text' ) );
$this->assertTrue( $registry->has_type( 'email' ) );
$this->assertTrue( $registry->has_type( 'url' ) );
$this->assertTrue( $registry->has_type( 'integer' ) );
$this->assertTrue( $registry->has_type( 'boolean' ) );
$this->assertTrue( $registry->has_type( 'date' ) );
$this->assertTrue( $registry->has_type( 'datetime' ) );
}
}

public function test_dataview_can_use_field_registery_with_custom_types(): void {
$registry = new FieldTypeRegistry();
$registry->register_type( 'custom_type', [
'dataset' => DataSet::TYPE_STRING,
'sanitizer' => fn( $value ) => ( $value ),
'schema' => [],
'input' => 'hidden',
] );

$config = [
'slug' => 'dv_test_custom_field_type',
'label' => 'Item',
'fields' => [
'name' => 'custom_type',
'title' => 'string',
]
];

try {
$view_default_registry = new DataView( $config );
$this->fail( 'Expected InvalidArgumentException was not thrown' );
} catch ( \InvalidArgumentException $e ) {
$this->assertStringStartsWith(
'Unknown field type "custom_type"',
$e->getMessage()
);
}

$view_custom_registry = new DataView( $config, $registry );
$this->assertInstanceOf( DataView::class, $view_custom_registry );
}

public function test_field_type_registry_maps_to_dataset_types(): void {
$registry = new FieldTypeRegistry();

Expand Down