fix(outbox): repair OutboxEntry hydration (delivery was broken)#7
Merged
Conversation
OutboxEntry's constructor was refactored — date fields became plain strings and locked_until/locked_by were added — but entry_from_row was never updated in lockstep. It omitted the two required locked_* args (ArgumentCountError) and wrapped the date fields in DateTimeImmutable where the constructor now expects raw strings. This never surfaced because the consumer DI that resolves OutboxProcessor was also incomplete, so the processor never ran and entry_from_row was never exercised. Once the processor resolves, every fetch hit this. Net effect: integration events were written to the outbox but never delivered on this code path. - Pass scheduled_at / next_attempt_at / created_at / processed_at as the raw stored strings (no DateTimeImmutable wrap). - Add locked_until and locked_by to the hydration. Verified end-to-end: pending event → process_batch → completed. Bumps 0.1.5 -> 0.1.6. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The wiring snippet emitted OutboxProcessor with 3 positional args in the wrong order (IOutboxRepository, IOutboxPublisher, OutboxConfig), omitting IDDDConfig entirely — it never matched the 4-arg constructor (IDDDConfig, IOutboxRepository, OutboxConfig, IOutboxPublisher). Any consumer pasting it got a broken processor. Emit `~` instead: autowired by type, all four deps are already registered, and it can't drift from constructor arg order — the exact failure that left the outbox undeliverable. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
OutboxRepository::entry_from_rowdrifted fromOutboxEntry's constructor:locked_until/locked_by→ArgumentCountErrorscheduled_at/next_attempt_at/created_at/processed_atinDateTimeImmutablewhere the constructor now wants rawstringImpact
Latent but serious: any consumer whose DI resolves
OutboxProcessorhits this on the first fetch. Net effect — integration events get written to the outbox but never delivered on this path. It stayed hidden because consumers with an incomplete DI never ran the processor, soentry_from_rowwas never exercised.Fix
Pass the date fields as raw stored strings; add the two
locked_*args.Verified
End-to-end on a live install: pending event →
process_batch→completed(1 total, 1 completed, 0 failed).206 unit tests pass. Version 0.1.5 → 0.1.6.
🤖 Generated with Claude Code