-
Notifications
You must be signed in to change notification settings - Fork 5
Update Link Component #1472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Link Component #1472
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| import { Link, useNavigate } from "@tanstack/react-router"; | ||
| import { useNavigate } from "@tanstack/react-router"; | ||
| import { type MouseEvent, useCallback } from "react"; | ||
|
|
||
| import type { PipelineRunResponse } from "@/api/types.gen"; | ||
|
|
@@ -15,6 +15,7 @@ import { | |
| TooltipContent, | ||
| TooltipTrigger, | ||
| } from "@/components/ui/tooltip"; | ||
| import { Paragraph } from "@/components/ui/typography"; | ||
| import useToastNotification from "@/hooks/useToastNotification"; | ||
| import { APP_ROUTES } from "@/routes/router"; | ||
| import { | ||
|
|
@@ -50,14 +51,6 @@ const RunRow = ({ run }: { run: PipelineRunResponse }) => { | |
|
|
||
| const clickThroughUrl = `${APP_ROUTES.RUNS}/${runId}`; | ||
|
|
||
| const LinkProps = { | ||
| to: clickThroughUrl, | ||
| className: "underline hover:text-blue-500 text-black", | ||
| onClick: (e: MouseEvent) => { | ||
| e.stopPropagation(); // Prevent triggering the row click handler | ||
| }, | ||
| }; | ||
|
|
||
| const createdByButton = ( | ||
| <Button | ||
| className="truncate underline" | ||
|
|
@@ -88,7 +81,7 @@ const RunRow = ({ run }: { run: PipelineRunResponse }) => { | |
| > | ||
| <TableCell className="text-sm flex items-center gap-2"> | ||
| <StatusIcon status={getRunStatus(statusCounts)} /> | ||
| <Link {...LinkProps}>{name}</Link> | ||
| <Paragraph>{name}</Paragraph> | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The row already has a handler to navigate to the url, so an embedded link to the same location is unnecessary |
||
| <span>{`#${runId}`}</span> | ||
| </TableCell> | ||
| <TableCell> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,46 +18,39 @@ function AppFooter() { | |
| > | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I know you didn't change it but can we make the footer component? I noticed, for some reason, these changes made the text on the footer sit a little high and this fixed it. <footer
className={`footer w-full px-4 text-center items-center bg-grey-50 h-[${BOTTOM_FOOTER_HEIGHT}px]`}
>
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are you sure? The text looks fine to me. Do you have a screenshot? I am going to merge and if this truly is an issue we can fix separately.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. its small but this is what I was seeing
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this is inadvertently fixed by #1484 |
||
| <InlineStack className="w-full" align="space-between"> | ||
| <div /> | ||
| <InlineStack gap="1" blockAlign="center"> | ||
| <Link | ||
| href={ABOUT_URL} | ||
| className="mx-1.5 text-blue-600 hover:text-blue-800 hover:underline" | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| > | ||
| <InlineStack gap="4" blockAlign="center"> | ||
| <Link href={ABOUT_URL} target="_blank" rel="noopener noreferrer"> | ||
| About | ||
| </Link> | ||
| <Link | ||
| href={GIVE_FEEDBACK_URL} | ||
| className="mx-1.5 text-blue-600 hover:text-blue-800 hover:underline" | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| > | ||
| Give feedback | ||
| </Link> | ||
| <Link | ||
| href={PRIVACY_POLICY_URL} | ||
| className="mx-1.5 text-blue-600 hover:text-blue-800 hover:underline" | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| > | ||
| Privacy policy | ||
| </Link> | ||
| Version: | ||
| <Link | ||
| href={`${GIT_REPO_URL}/commit/${GIT_COMMIT}`} | ||
| className="mx-1.5 text-blue-600 hover:text-blue-800 hover:underline" | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| > | ||
| {GIT_COMMIT.substring(0, 6)} | ||
| </Link> | ||
| <InlineStack gap="1" blockAlign="center"> | ||
| Version: | ||
| <Link | ||
| href={`${GIT_REPO_URL}/commit/${GIT_COMMIT}`} | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| > | ||
| {GIT_COMMIT.substring(0, 6)} | ||
| </Link> | ||
| </InlineStack> | ||
| </InlineStack> | ||
| <Text size="xs" font="mono" tone="subdued"> | ||
| Built with{" "} | ||
| <Link | ||
| href="https://reactflow.dev" | ||
| className="text-blue-400 hover:text-blue-600 hover:underline" | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| > | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.