Skip to content

Conversation

@maxy-shpfy
Copy link
Collaborator

@maxy-shpfy maxy-shpfy commented Dec 7, 2025

Description

Added a test dialog component to demonstrate dialog functionality. The implementation includes:

  • A new TestDialogButton component that opens a demo dialog
  • A reusable TestDialog component that shows how to pass data back to the parent
  • A useConfirmationDialog hook for creating nested confirmation dialogs
  • Integration of the test button in the Pipeline Details view

The dialog system supports typed results, nested dialogs, and proper error handling for dialog cancellation.

Test Instructions

Screen Recording 2025-12-06 at 5.33.55 PM.mov (uploaded via Graphite)

  1. Navigate to the Pipeline Details view
  2. Click the "Open Test Dialog" button
  3. Test the dialog functionality including:
    • Modifying the message text
    • Opening a nested confirmation dialog
    • Canceling and confirming dialogs
    • Observing toast notifications with dialog results

Additional Comments

This implementation demonstrates the pattern for creating and using dialogs throughout the application. The dialog system handles stacking, typed results, and proper cancellation flows.

Copy link
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@maxy-shpfy maxy-shpfy force-pushed the 12-06-poc_new_dialog_system_usage_example branch from 1f2a12a to dbd2581 Compare December 7, 2025 23:47
@maxy-shpfy maxy-shpfy force-pushed the 12-06-poc_create_dialog_stackable_system_compatible_with_router_and_promises branch from ec859e0 to 4d89784 Compare December 7, 2025 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants