[Refactor] #510 - DTO-Entity 분리 및 최신 컨벤션 반영 #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guryss
reviewed
Mar 26, 2025
|
|
||
| struct NovelReviewEntity { | ||
| let novelTitle: String | ||
| let status: String? |
Member
There was a problem hiding this comment.
W1;
작품 리뷰 status를 Enum으로 관리하는 건 어떨까요?
enum NovelReviewStatus {
case reading
case finish
case drop
}이런 느낌으로 ...
| let startDate: Date? | ||
| let endDate: Date? | ||
| let userNovelRating: Float | ||
| let attractivePoints: [String] |
Member
There was a problem hiding this comment.
W1;
매력포인트 값들도 enum으로 관리해보는 게 어떨지요..?
let attractivePoints: [AttractivePointType]
enum AttractivePointType {
case world
case subject
case character
case relationship
case vibe
}| .subscribe(with: self, onNext: { owner, buttonType in | ||
| if buttonType == .left { | ||
| owner.stopEditingEvent.accept(()) | ||
| owner.navigationController?.popViewController(animated: true) |
Member
There was a problem hiding this comment.
Suggested change
| owner.navigationController?.popViewController(animated: true) | |
| owner.popToLastViewController() |
| .subscribe(with: self, onNext: { owner, buttonType in | ||
| if buttonType == .left { | ||
| owner.stopReviewingEvent.accept(()) | ||
| owner.navigationController?.popViewController(animated: true) |
Member
There was a problem hiding this comment.
Suggested change
| owner.navigationController?.popViewController(animated: true) | |
| owner.popToLastViewController() |
Naknakk
reviewed
Mar 29, 2025
Contributor
Naknakk
left a comment
Naknakk
left a comment
There was a problem hiding this comment.
구리스 제안이 좋네용 저두 Entity는 서버에서 준 데이터를 우리가 만든 모델로 바꿔주는게 베스트라구 생각합니다!!
Guryss
reviewed
Apr 29, 2025
Member
Guryss
left a comment
Guryss
left a comment
There was a problem hiding this comment.
반영해주셔서 검사합니당!
리뷰 하나 더 남겼으니 확인 부탁드려용
Comment on lines
+22
to
+25
| let dateFormatter = DateFormatter().then { | ||
| $0.dateFormat = "yyyy-MM-dd" | ||
| $0.timeZone = TimeZone(identifier: "ko_KR") | ||
| } |
Member
There was a problem hiding this comment.
해당 변수를 DateFormatter 익스텐션으로 빼서 static 변수로 만드는 게 기능상 좋아보입니다!
DateFormatter는 내부적인 계산이 많이 들어가는 값이기 떄문에 static 변수로 빼서 한번만 생성되고 앱 내에서 재사용 되는 방법이 어떨까요?
extension DateFormatter {
static let dateFormatter: DateFormatter = {
let formatter = DateFormatter()
formatter.dateFormat = "yyyy-MM-dd"
formatter.timeZone = TimeZone(identifier: "ko_KR")
return formatter
}()
}func toEntity() -> NovelReviewEntity {
let formatter = DateFormatter.dateFormatter
let startDate = self.startDate.flatMap { formatter.date(from: $0) }
let endDate = self.endDate.flatMap { formatter.date(from: $0) }
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⭐️Issue
🌟Motivation
DTO-Entity 분리 및 최신 컨벤션 반영
🌟Key Changes
🌟Simulation
X
🌟To Reviewer
X
🌟Reference
X