Open
Conversation
afranchuk
previously requested changes
Mar 5, 2026
afranchuk
approved these changes
Mar 7, 2026
bjmcternan
reviewed
Mar 7, 2026
bjmcternan
reviewed
Mar 7, 2026
| * and radians | ||
| * @param visionStandardDeviation The standard deviation for vision calculation | ||
| * in the form [x, y, theta], with units in meters | ||
| * in the form [x, y, theta]áµ€, with units in meters |
Contributor
There was a problem hiding this comment.
Remove the áµ€ character
bjmcternan
requested changes
Mar 7, 2026
Contributor
bjmcternan
left a comment
bjmcternan
left a comment
There was a problem hiding this comment.
Looks like that character snuck through
Contributor
|
Tune drivetrain also means tuning the PIDs and changing the motor IDs to be more consistent. We should tune the PIDs and everything else before we merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #40
Reran the swerve drive project generator with Phoenix Tuner and regenerated the CAN Ids and the constants.