Clamp AndroidFlingSpline.flingPosition to prevent array OOB - #29
Open
tonycoder-hub wants to merge 1 commit into
Open
Clamp AndroidFlingSpline.flingPosition to prevent array OOB#29tonycoder-hub wants to merge 1 commit into
tonycoder-hub wants to merge 1 commit into
Conversation
Play time can be slightly below the animation start when the frame clock is not monotonic. (NbSamples * time).toInt() then becomes negative and SplinePositions[index] throws ArrayIndexOutOfBoundsException (Tencent-TDS#18). Port the published AndroidX compose-animation 1.7.0 workaround (9d47587, b/313685022): coerce time into [0, 1] before indexing. Test: AndroidFlingSplineTest#testClampedOutOfRangePosition Co-authored-by: Tony Jin <407243179@qq.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
9d47587, b/313685022) into this 1.6.1 tree.index = (NbSamples * time).toInt()goes negative and Kotlin Native throwsArrayIndexOutOfBoundsException(flingPosition caused array out of bounds exception #18).timeto[0, 1]before indexing. Same workaround that shipped upstream.Test plan
AndroidFlingSplineTest#testClampedOutOfRangePosition— out-of-range inputs (-10,-1,-0.06,1.5,10) match the0/1endpoints and do not throw.Fixes #18