fix: leftover ArkUI C ABI null deref on prepareDraw/sendMessage - #30
Open
tonycoder-hub wants to merge 1 commit into
Open
Conversation
Kotlin/NAPI can pass null during teardown or when XComponent is missing. leftover prepareDraw/finishDraw/registerFrameCallback/ unregisterFrameCallback and leftover sendMessage dereferenced without the sibling getId null guard. Extract leftover if (!p) return false helper so host tests compile without Harmony/NAPI. Test: leftover_c_abi_null_guard_test Signed-off-by: Tony Coder <407243179@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
leftover
Kotlin/NAPI can pass a null
render/controllerduring teardown or when the XComponent is missing. SiblinggetIdalready null-guards; leftoverprepareDraw/finishDraw/registerFrameCallback/unregisterFrameCallback/sendMessagedereferenced without that check and crash.This leftover adds the same null guard and extracts a tiny helper so host tests compile without Harmony/NAPI.
Host test (no Harmony device):
Signed-off-by: Tony Coder 407243179@qq.com