fix(agent-scan): register 4 new detection skills in _DETECTION_SKILLS#452
Open
boy-hack wants to merge 1 commit into
Open
fix(agent-scan): register 4 new detection skills in _DETECTION_SKILLS#452boy-hack wants to merge 1 commit into
boy-hack wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four detection skills added in PR #444 were never registered in
_DETECTION_SKILLSinagent-scan/core/agent.py, so they were silently never executed during agent scans.Root Cause
PR #444 added 4 new skill files under
agent-scan/prompt/skills/but did not update the_DETECTION_SKILLSlist inagent.py. This list controls which skills are actually spawned as workers during Stage 2 of an agent scan.Fix
Added the 4 missing skills to
_DETECTION_SKILLS:Impact
After this fix, agent scans will detect:
direct-injection-detection) — ASI01file-path-traversal-detection) — ASI05hardcoded-secret-detection) — ASI06memory-poisoning-detection) — ASI06These are critical security detection capabilities that were previously available but silently skipped.
Reference: PR #429 (by @DevamShah) correctly demonstrated the pattern — both SKILL.md + agent.py registration in the same PR.