Repository navigation
Conversation
Contributor
|
This pull request was closed by a temporary author restriction. Pull requests may only be opened by:
Ask a maintainer to add your GitHub login to that allowlist, then reopen the pull request. 此 Pull Request 已被临时的作者限制自动关闭。 当前仅允许以下用户创建 PR:
如需在首次合入前贡献,请联系维护者把 GitHub 用户名加入允许名单,然后再重新打开这个 PR。 维护者可将仓库变量 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2881. A per-user macOS LaunchAgent starts with a system-only PATH, so Octop cannot find Homebrew's
adbeven when it works in the user's shell.Generate a fixed PATH for user LaunchAgents with the macOS system directories first, followed by the standard Apple Silicon and Intel Homebrew bin directories. The renderer does not inherit the installer's shell PATH or change system LaunchDaemons. Existing custom plists are preserved during normal startup; users can regenerate an existing managed plist explicitly with
octop service start --scope user --force-install.Target branch
developType of change
Test plan
KeyError: 'PATH'and passed afterward. It checks both Homebrew prefixes, system directory precedence, and that the installer's PATH is not copied. The system-scope test verifies that LaunchDaemons still do not set PATH.uv run --no-sync pytest -q tests/unit/infra/setup/test_service.py tests/unit/mobile/test_find_adb.py tests/unit/cli/test_service_cmd.py— 66 passed on Linux.make lint typecheck RUN='uv run --no-sync'— Ruff lint/format and mypy passed.Checklist