Skip to content

Conversation

@akomakom
Copy link
Contributor

@akomakom akomakom commented Apr 16, 2020

  • core never enforced header licenses due to a pom error. Using new parent that enforces licenses.
  • All headers have been brought in sync using mvn license:format
  • Due to a change in license plugin configuration, a trailing blank line is removed from all files.
  • parent also adds spotbugs execution

@akomakom akomakom force-pushed the enforce-licenses branch 2 times, most recently from 0ef5feb to 383ca92 Compare April 16, 2020 21:53
@akomakom akomakom requested a review from myronkscott April 17, 2020 01:03
@akomakom
Copy link
Contributor Author

@myronkscott I have these options:

  1. Disable spotbugs for now and deal with fixing violations in a separate PR
  2. Fix them in this PR

The downside of option 2 is that the diff is already overwhelming. But it's fine with me.

@myronkscott
Copy link
Member

Disable spot bugs for this repo. Too much legacy to deal with. I don’t think it is worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants