fix(data): derive saved totals from WHERE and keep fines honest - #78
Merged
Merged
Conversation
ThatAlexPalmer
marked this pull request as ready for review
September 8, 2026 12:14
ThatAlexPalmer
force-pushed
the
grokbot/honest-totals-fines-errors-6736
branch
from
September 8, 2026 13:31
1975a02 to
87cbe38
Compare
ThatAlexPalmer
changed the base branch from
main
to
grokbot/writer-env-helper-0b23
September 8, 2026 13:31
Saved scope totals now follow the WHERE queryLaws already built so a missed filter cannot overstate the rail. LawSummary.fine is required on list and notable-law rows. County-fill errors keep penalties; incomplete national and place-lookup HTTP failures no longer look ready or empty. Co-authored-by: Alex Palmer <ThatAlexPalmer@users.noreply.github.com>
cursor
Bot
force-pushed
the
grokbot/writer-env-helper-0b23
branch
from
September 9, 2026 16:39
a925726 to
29e7606
Compare
cursor
Bot
force-pushed
the
grokbot/honest-totals-fines-errors-6736
branch
from
September 9, 2026 16:39
87cbe38 to
5900d6e
Compare
cursor
Bot
changed the base branch from
grokbot/writer-env-helper-0b23
to
main
September 9, 2026 16:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Saved scope totals now follow the WHERE
queryLawsalready built.LawSummary.fineisnumber | nullon list and notable-law rows. County-fill errors keep penalties. Incomplete national throws instead of"ready". Place lookup HTTP failures throw instead of[].Why?
A parallel filter list overstates the rail when a field is missed. Core failures must not look empty or ready. One DTO, one WHERE, honest errors.
Testing
pnpm lint,pnpm typecheck, andpnpm testall passed (101 unit tests). Fixes #76.