Skip to content

Conversation

@openroad-ci
Copy link
Collaborator

(Not working due to abc exported header issue)

(Not working due to abc exported header issue)

Signed-off-by: Matt Liberty <[email protected]>
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@maliberty
Copy link
Member

@mikesinouye this still fails with

src/rmp/src/abc_library_factory.h:14:10: error: use of private header from outside its module: 'map/scl/sclLib.h' [-Wprivate-header]
   14 | #include "map/scl/sclLib.h"

Adding your define doesn't change that. I don't know why it would work for you.

@maliberty
Copy link
Member

maliberty commented Aug 20, 2025

In https://github.com/hdl/bazel_rules_hdl/blob/main/dependency_support/edu_berkeley_abc/bundled.BUILD.bazel the only exported headers I see are:

    hdrs = [
        "src/base/abc/abc.h",
        "src/base/main/main.h",
        "src/misc/util/abc_global.h",
    ],

which doesn't include the ones rmp is using.

@maliberty
Copy link
Member

maliberty commented Aug 20, 2025

I see in abc-lib.cppmap (auto-generated):

  private textual header "../../../../../external/edu_berkeley_abc/src/map/scl/sclLib.h"

@mikesinouye
Copy link
Contributor

Ah I see, the internal abc BUILD we use exported these, so I didn't run into that. We should be set with hdl/bazel_rules_hdl#419.

"//src/odb",
"//src/rsz",
"//src/utl",
"@edu_berkeley_abc//:abc-lib",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might also need

        "@boost.bind",
        "@boost.config",
        "@boost.fusion",
        "@boost.lambda",
        "@boost.optional",
        "@boost.phoenix",
        "@boost.spirit",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I did need those once I got passed abc. I also could prune some unneeded ones.

Thanks for the bazel-rules PR to enable this.

Signed-off-by: Matt Liberty <[email protected]>
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@maliberty maliberty enabled auto-merge August 20, 2025 23:37
@maliberty maliberty disabled auto-merge August 21, 2025 02:16
@maliberty maliberty merged commit 05f2e3f into The-OpenROAD-Project:master Aug 21, 2025
10 of 11 checks passed
@maliberty maliberty deleted the rmp-bzl2 branch August 21, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants