-
Notifications
You must be signed in to change notification settings - Fork 744
rmp: add Bazel BUILD #8074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rmp: add Bazel BUILD #8074
Conversation
(Not working due to abc exported header issue) Signed-off-by: Matt Liberty <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@mikesinouye this still fails with Adding your define doesn't change that. I don't know why it would work for you. |
|
In https://github.com/hdl/bazel_rules_hdl/blob/main/dependency_support/edu_berkeley_abc/bundled.BUILD.bazel the only exported headers I see are: which doesn't include the ones rmp is using. |
Signed-off-by: Matt Liberty <[email protected]>
Signed-off-by: Matt Liberty <[email protected]>
|
I see in abc-lib.cppmap (auto-generated): |
|
Ah I see, the internal abc BUILD we use exported these, so I didn't run into that. We should be set with hdl/bazel_rules_hdl#419. |
| "//src/odb", | ||
| "//src/rsz", | ||
| "//src/utl", | ||
| "@edu_berkeley_abc//:abc-lib", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might also need
"@boost.bind",
"@boost.config",
"@boost.fusion",
"@boost.lambda",
"@boost.optional",
"@boost.phoenix",
"@boost.spirit",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks I did need those once I got passed abc. I also could prune some unneeded ones.
Thanks for the bazel-rules PR to enable this.
Signed-off-by: Matt Liberty <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Matt Liberty <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
05f2e3f
into
The-OpenROAD-Project:master
(Not working due to abc exported header issue)