Skip to content

Add Merge Sort Linked List algorithm - #11695

Merged
cclauss merged 19 commits into
TheAlgorithms:masterfrom
Hardvan:merge_sort_linked_list_new_algo
Sep 11, 2026
Merged

cclauss merged 19 commits into
TheAlgorithms:masterfrom
Hardvan:merge_sort_linked_list_new_algo

Conversation

@Hardvan

@Hardvan Hardvan commented Oct 3, 2024

Copy link
Copy Markdown
Contributor

The Merge Sort for Linked List algorithm sorts a linked list by recursively dividing it into two halves, sorting each half, and then merging the sorted halves back together. It uses the divide-and-conquer approach and the merge step to ensure that the resulting linked list is sorted. The key steps include finding the middle of the list to divide it and merging two sorted lists.

Algorithm Steps:

  1. Base Case: If the list is empty or contains a single node, it is already sorted.
  2. Dividing the List: Use the slow and fast pointer technique to find the middle of the linked list. Split the list into two halves.
  3. Recursive Sorting: Recursively apply merge sort to both the left and right halves of the list.
  4. Merge Step: Merge the two sorted halves into a single sorted linked list using a helper function that compares the nodes of both lists and links them in order.
  5. Result: The sorted linked list is returned after all recursive calls are complete and all sublists have been merged.
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper Bot added the require type hints https://docs.python.org/3/library/typing.html label Oct 3, 2024

@algorithms-keeper algorithms-keeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment thread data_structures/linked_list/merge_sort_linked_list.py Outdated
@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Oct 3, 2024
@algorithms-keeper algorithms-keeper Bot removed the require type hints https://docs.python.org/3/library/typing.html label Oct 3, 2024
@algorithms-keeper algorithms-keeper Bot added the tests are failing Do not merge until tests pass label Oct 3, 2024
@algorithms-keeper algorithms-keeper Bot removed the tests are failing Do not merge until tests pass label Oct 3, 2024
Refactor Node class to use dataclass for attributes and update iter_linked_list to yield node data. Remove print_linked_list function and update merge function to use direct comparison.

@cclauss cclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @Hardvan

Please see some useful changes in my last commit:

  • I used Python's ordered dataclasses to define the Node, which enables direct comparison on line 107.
  • I used an iter function (you will need one anyway) to replace the complexities of printing and showing/testing the unsorted lists before sorting them.

@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Sep 11, 2026
@cclauss
cclauss merged commit 37d41a7 into TheAlgorithms:master Sep 11, 2026
6 checks passed
@cclauss cclauss mentioned this pull request Sep 11, 2026
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants