docs(skill): suggest NamedTuple/dataclass for simple field-bundle classes - #15224
Merged
cclauss merged 1 commit intoSep 8, 2026
Merged
Conversation
…sses Per maintainer request on TheAlgorithms#15081: the new-pull-request skill now reminds the coder to consider `typing.NamedTuple` / `dataclasses.dataclass` for simple classes, and the code-review skill adds an OPTIONAL reviewer hint to suggest them where they simplify the code (never a blocker).
cclauss
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on #15081.
Describe your change:
Adds a small, optional guideline to both agent skill files:
new-pull-request/SKILL.md(coder): a checklist item to considerfrom typing import NamedTupleorfrom dataclasses import dataclassfor a simple class that is mostly a bundle of fields, instead of a hand-written__init__/__repr__/__eq__.code-review/SKILL.md(reviewer): an optional reviewer hint to suggest those tools where they would simplify the code — explicitly not a blocker / not grounds to request changes on their own.These are underutilized tools that make simple classes shorter and clearer, and this nudges contributors (human or AI) toward them where they make sense.
Checklist: