Skip to content

Fix recursive_match treating x* as matching any character - #15782

Open
JayPokale wants to merge 1 commit into
TheAlgorithms:masterfrom
JayPokale:fix-recursive-regex-star
Open

JayPokale wants to merge 1 commit into
TheAlgorithms:masterfrom
JayPokale:fix-recursive-regex-star

Conversation

@JayPokale

Copy link
Copy Markdown

Describe your change

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

dynamic_programming/regex_match.py::recursive_match handled a trailing * by dropping the last text character without checking that it equals the starred element. recursive_match('abbb', 'a*') and recursive_match('ab', 'ac*') returned True. dp_match in the same file is right. Against re.fullmatch, 2520 of 20000 random text and pattern pairs over a, b and . with optional * disagreed on master.

The character is now dropped only when it equals the starred element or the element is .. I added doctests for the cases above (they fail on master); the added doctests are the regression evidence for this one function, so I kept them in the same PR.

After the change, 60000 random pairs agree with re.fullmatch. ruff check, ruff format --check and python -m doctest pass.

Written with the help of Claude Code (Claude Sonnet 5.5).

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues, then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

The trailing-star branch dropped the last text character without checking it against the starred element, so recursive_match('abbb', 'a*') and recursive_match('ab', 'ac*') returned True. Drop it only when it equals the element or the element is a dot.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant