Repository navigation
Conversation
The trailing-star branch dropped the last text character without checking it against the starred element, so recursive_match('abbb', 'a*') and recursive_match('ab', 'ac*') returned True. Drop it only when it equals the element or the element is a dot.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
dynamic_programming/regex_match.py::recursive_matchhandled a trailing*by dropping the last text character without checking that it equals the starred element.recursive_match('abbb', 'a*')andrecursive_match('ab', 'ac*')returnedTrue.dp_matchin the same file is right. Againstre.fullmatch, 2520 of 20000 random text and pattern pairs overa,band.with optional*disagreed onmaster.The character is now dropped only when it equals the starred element or the element is
.. I added doctests for the cases above (they fail onmaster); the added doctests are the regression evidence for this one function, so I kept them in the same PR.After the change, 60000 random pairs agree with
re.fullmatch.ruff check,ruff format --checkandpython -m doctestpass.Written with the help of Claude Code (Claude Sonnet 5.5).
Checklist