Skip to content

Fix knapsack for a zero capacity or no items - #15783

Open
JayPokale wants to merge 1 commit into
TheAlgorithms:masterfrom
JayPokale:fix-knapsack-zero-capacity
Open

JayPokale wants to merge 1 commit into
TheAlgorithms:masterfrom
JayPokale:fix-knapsack-zero-capacity

Conversation

@JayPokale

Copy link
Copy Markdown

Describe your change

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

dynamic_programming/knapsack.py::knapsack returned dp[n][w_], where w_ is the loop variable over capacities. With a capacity of 0 or with no items the loop never runs, so knapsack(0, [1], [5], 1) and knapsack_with_example_solution(5, [], []) raised UnboundLocalError. It now returns dp[n][w], which is the same cell whenever the loop ran.

I added two doctests to knapsack_with_example_solution for those cases (they fail on master); the added doctests are the regression evidence for this one function, so I kept them in the same PR. Over 5000 random instances (capacity 0 to 15, 0 to 6 items) the value matches a one-dimensional DP and the returned item set fits the capacity and sums to the value. ruff check, ruff format --check and python -m doctest pass.

Written with the help of Claude Code (Claude Sonnet 5.5).

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues, then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

knapsack returned dp[n][w_] with w_ being the loop variable, so a capacity of 0 or no items raised UnboundLocalError. Return dp[n][w] instead.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant