Skip to content

Fix handle jest v27 fake timers (issue #30) - #38

Open
wilsonpage wants to merge 1 commit into
TheBrainFamily:masterfrom
wilsonpage:fix-fake-timers
Open

Fix handle jest v27 fake timers (issue #30)#38
wilsonpage wants to merge 1 commit into
TheBrainFamily:masterfrom
wilsonpage:fix-fake-timers

Conversation

@wilsonpage

Copy link
Copy Markdown

The existing check for jest fake timers no longer works as jest v27 mutates the setTimeout global differently. This patch checks for both the old and new formats.

The existing check for jest fake timers no longer works as jest v27 mutates the `setTimeout` global differently. This patch checks for both the old and new formats.
@lgandecki

Copy link
Copy Markdown
Member

Thanks, do you think this works too? #37

I like that it also upgrades the jest so the tests verify the change

@wilsonpage

Copy link
Copy Markdown
Author

Thanks, do you think this works too? #37

I like that it also upgrades the jest so the tests verify the change

👍 Looks like a better PR. You should merge that one.

@devlato

devlato commented Jan 29, 2025

Copy link
Copy Markdown

I can recommend an alternative if you're interested :)

https://github.com/devlato/async-wait-until

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants