Replace evergreen-tree byte encoding with Unicode encoding to prevent VS warnings #1741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest Visual Studio compiler raises a warning in our client code:
sol2\include\sol\inheritance.hpp(56,29): warning C5321: nonstandard extension used \'xF0\' as a multi-bute utf-8 character. Use \u instead for cross platform compatibility or \'Zc:u8EscapeEncoding\' to disable the extension.I raised here an issue at MS. At that time adding the recommended compiler switch was the easier solution. But we are now facing the problem in more and more products who use the Sol library and so I decided to create this PR.
I noticed during my fix that the
base_class_index_propagation_key()function and the one below are nowhere referenced in the whole repo. Purpose or accident?