Fix head names showing as 's Head#86
Open
MaximumWoahverdrive wants to merge 1 commit intoTheSilentPro:masterfrom
Open
Fix head names showing as 's Head#86MaximumWoahverdrive wants to merge 1 commit intoTheSilentPro:masterfrom
MaximumWoahverdrive wants to merge 1 commit intoTheSilentPro:masterfrom
Conversation
…:item_name being lowest priority and being overriden by dynamic "'s Head"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On current minecraft versions, clients show both navigation and actual heads as
's Headbecause the name dynamically generated from the minecraft:profile takes priority over the minecraft:item_name.see PaperMC/Paper#13613 and https://www.minecraft.net/en-us/article/minecraft-snapshot-24w37a
To work around this, set the higher priority displayName with italics disabled.
Since we don't have adventure apis in the LegacyItemFactory, the italics disable override was not added there. Since i don't have a legacy server install to test with, i have not confirmed this. At worst this results in italicized head names.
Tested on Purpur 1.21.11-2558
Fixes #84