Skip to content

fix(mobile): keep clip start fixed while extending - #296

Merged
sjungwon03 merged 1 commit into
devfrom
fix/295-fixed-start-trim-preview
Aug 24, 2026
Merged

fix(mobile): keep clip start fixed while extending#296
sjungwon03 merged 1 commit into
devfrom
fix/295-fixed-start-trim-preview

Conversation

@sjungwon03

Copy link
Copy Markdown
Member

Summary

  • Preview right-edge and long-press trimming by changing only clip width.
  • Preserve the clip start position while extending its trailing edge.
  • Preserve left-edge and ordinary move behavior.

Verification

  • Mobile typecheck passed.
  • Mobile timeline gesture and shared timeline tests passed: 22 tests.

Closes #295

@sjungwon03-ai sjungwon03-ai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the exact head: the split preview state keeps the leading edge fixed for right trims and retains the left-trim and move transforms. Approval is pending the exact-head android-module and ios-module builds, which are still running.

@sjungwon03-ai sjungwon03-ai added the review:commented Review comments posted label Aug 24, 2026

@sjungwon03-ai sjungwon03-ai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exact-head native builds are now complete. Confirmed the right-trim preview changes width without translating the leading edge, while the left-trim and move paths remain distinct. The direct-head verify, android-module, ios-module, and ios-export checks all passed.

@sjungwon03-ai sjungwon03-ai added review:approved Latest-head review approved and removed review:commented Review comments posted labels Aug 24, 2026
@sjungwon03
sjungwon03 merged commit 6b3064d into dev Aug 24, 2026
4 checks passed
@sjungwon03
sjungwon03 deleted the fix/295-fixed-start-trim-preview branch August 24, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved Latest-head review approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(mobile): keep clip start fixed while extending trim

2 participants