Skip to content

Fix "You must specify at least one part" error#5750

Merged
ypatia merged 2 commits into
mainfrom
vlasisPit/CLOUD-3516/bug-you-must-specify-at-least-one-part-error
Feb 19, 2026
Merged

Fix "You must specify at least one part" error#5750
ypatia merged 2 commits into
mainfrom
vlasisPit/CLOUD-3516/bug-you-must-specify-at-least-one-part-error

Conversation

@vlasisPit
Copy link
Copy Markdown
Contributor

@vlasisPit vlasisPit commented Feb 13, 2026

After error `BadDigest Message: The CRC64NVME you specified did not match the calculated checksum.` uploading a part fails. Then error `You must specify at least one part` appears because the CompleteUpload can not succeed Screenshot 2026-02-13 at 2 08 34 PM

This PR adds checks to ensure completed_parts is not empty before calling CompleteMultipartUpload


TYPE: IMPROVEMENT
DESC: Fix "You must specify at least one part" error

@vlasisPit vlasisPit requested a review from ypatia February 13, 2026 12:05
@vlasisPit
Copy link
Copy Markdown
Contributor Author

Is this one still needed, or should we close it?

@vlasisPit vlasisPit requested a review from ihnorton February 17, 2026 16:05
Copy link
Copy Markdown
Member

@teo-tsirpanis teo-tsirpanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to PutObject an empty object if the multipart upload ends up having no parts.

Also, if uploading a part fails, should we instead remove it from the states table?

@ypatia
Copy link
Copy Markdown
Member

ypatia commented Feb 19, 2026

Also, if uploading a part fails, should we instead remove it from the states table?

@teo-tsirpanis I created https://linear.app/tiledb/issue/CORE-503/add-proper-cleanup-after-an-error-occurs-in-multi-part-uploads for following up on proper multi-part upload handling.

I think it would be better to PutObject an empty object if the multipart upload ends up having no parts.

Could you push a fix about your suggestion? Otherwise we can close this PR and fix it as part of CORE-503

Copy link
Copy Markdown
Member

@teo-tsirpanis teo-tsirpanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, this change looks good for now. The completed parts won't be empty unless uploading a part has failed, in which case we should not upload an empty object.

@ypatia ypatia merged commit 2c2d769 into main Feb 19, 2026
56 checks passed
@ypatia ypatia deleted the vlasisPit/CLOUD-3516/bug-you-must-specify-at-least-one-part-error branch February 19, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants