Fix "You must specify at least one part" error#5750
Conversation
|
Is this one still needed, or should we close it? |
…-least-one-part-error
teo-tsirpanis
left a comment
There was a problem hiding this comment.
I think it would be better to PutObject an empty object if the multipart upload ends up having no parts.
Also, if uploading a part fails, should we instead remove it from the states table?
@teo-tsirpanis I created https://linear.app/tiledb/issue/CORE-503/add-proper-cleanup-after-an-error-occurs-in-multi-part-uploads for following up on proper multi-part upload handling.
Could you push a fix about your suggestion? Otherwise we can close this PR and fix it as part of CORE-503 |
teo-tsirpanis
left a comment
There was a problem hiding this comment.
On second thought, this change looks good for now. The completed parts won't be empty unless uploading a part has failed, in which case we should not upload an empty object.
This PR adds checks to ensure completed_parts is not empty before calling CompleteMultipartUpload
TYPE: IMPROVEMENT
DESC: Fix "You must specify at least one part" error