Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This comment has been minimized.
This comment has been minimized.
b7r6
force-pushed
the
ci/nightly-redundant-lanes
branch
from
October 3, 2026 20:32
5356c33 to
d1a9e1e
Compare
b7r6
force-pushed
the
ci/nightly-redundant-lanes
branch
from
October 3, 2026 20:37
d1a9e1e to
49a657f
Compare
b7r6
changed the title
b7r6
force-pushed
the
ci/nightly-redundant-lanes
branch
from
October 3, 2026 20:48
49a657f to
2265ca7
Compare
b7r6
changed the title
b7r6
force-pushed
the
ci/nightly-redundant-lanes
branch
from
October 3, 2026 20:57
2265ca7 to
da552fe
Compare
MarcusSorealheis
requested changes
Oct 3, 2026
MarcusSorealheis
left a comment
MarcusSorealheis
left a comment
Member
There was a problem hiding this comment.
We cannot move all of rbe testing to nightly.
Defer CI lanes that are redundant with another per-PR lane, or expensive and non-gating, to a nightly schedule (0 7 * * * UTC) + workflow_dispatch. Per-PR keeps Bazel Dev, the install smoke test, and NativeLink's own RBE toolchain matrix; the rest runs nightly. - Cargo Native (Linux + Windows): nightly. - Cargo Dev (nix-cargo): nightly. - Integration (buildstream/buck2/mongo): nightly; core build/test covered per-PR by Bazel Dev. - Coverage: nightly + push:main (xlarge, 180-min, non-gating). Kept per-PR: Bazel Dev, installation, RBE toolchain matrix (generate-rbe-commands + rbe-toolchain), asan, Bazel Native, LRE, lints. CodeQL is a required check, left for a coordinated branch-protection follow-up.
b7r6
changed the title
b7r6
force-pushed
the
ci/nightly-redundant-lanes
branch
from
October 3, 2026 21:05
da552fe to
7ef505e
Compare
b7r6
pushed a commit
to b7r6/nativelink
that referenced
this pull request
Oct 4, 2026
Combines TraceMachina#2877 + TraceMachina#2878 + TraceMachina#2880 on one branch so a single CI run shows the true end-state per-PR wall clock. Not for merge: the individual PRs are the review units; this exists to measure their net effect.
b7r6
pushed a commit
to b7r6/nativelink
that referenced
this pull request
Oct 4, 2026
Combines TraceMachina#2877 + TraceMachina#2878 + TraceMachina#2880 on one branch so a single CI run shows the true end-state per-PR wall clock. Not for merge: the individual PRs are the review units; this exists to measure their net effect.
Contributor
Author
|
@MarcusSorealheis I think we got those back in on Saturday, or am I conflating the pictued lanes with the ones you mean? This is the most recent run. 
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Defers CI lanes that are redundant with another per-PR lane, or expensive and non-gating, to a nightly schedule (
0 7 * * *UTC) +workflow_dispatch, to cut PR latency. Per-PR keeps the primary build/test signal plus NativeLink's own RBE lanes.nix-cargo) → nightly.push:main(xlarge runner, 180-min cap, non-gating/no floor; the Pages trend still updates on merge).Kept per-PR: Bazel Dev, installation (nix-run smoke), the RBE toolchain matrix (
generate-rbe-commands+rbe-toolchain— NativeLink's own remote-execution path, the signal worth running on every change), asan, Bazel Native, LRE, and all lints. Jobs that stay per-PR are gated!= 'schedule'so they don't fire on the nightly run.CodeQL is a required status check — moving it off
pull_requestneeds a coordinated branch-protection change, so it is left for a follow-up.How was this verified?
All three workflow files YAML-validated, and the gating traced per event: on
pull_request, the deferred lanes (cargo, Cargo Dev, integration, coverage) are skipped while Bazel Dev + installation + the RBE toolchain matrix + asan + Bazel Native + LRE + lints run; onschedule, the deferred lanes run and the per-PR-only jobs are skipped; a single shared cron exercises the whole deferred set. Not yet observed on a live nightly tick — the first scheduled run will confirm the deferred lanes fire.Risk
Low and contained — only when these lanes run changes, not what they do. The deliberate tradeoffs: no per-PR Windows cargo coverage and no per-PR end-to-end integration; each is validated nightly against
mainand on-demand. The primary per-PR build/test signal (Bazel Dev), the RBE toolchain matrix, and the memory/race signal (asan) are unchanged. No source, config, or wire-format changes.AI assistance
An agent (Claude Code) drafted these workflow edits and this description; I reviewed every line and verified the trigger/gating logic and YAML myself.