Record a sampled elimination's bag before the vertex leaves the graph - #64
Merged
Conversation
Sampled min-fill takes a vertex out of the graph and then repairs the fill scores of its neighbours, reading the hard deadline as it goes. A run stopped in that repair had already removed the vertex but had not recorded its bag, and the engine's residual bag covers only what is still in the graph, so the vertex ended up in no bag at all. A debug build caught it in build_td as a rank past the bag count. A release build has no such check and returned the decomposition: on a 2,000-vertex chorded ring stopped at an expired deadline it fails validation with "vertex 509 is in no bag". The bag is now recorded as soon as it is read, before the elimination and before anything can stop the run. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
guyvdbroeck
marked this pull request as ready for review
September 6, 2026 09:10
The comparison table takes main's row until the merged binary is measured. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A sampled min-fill or fill-degree elimination stopped by the hard deadline while repairing its neighbours' scores has already removed the vertex but not recorded its bag. The engine's residual bag covers only the vertices still in the graph, and the portfolio does not validate what it returns, so the decomposition reaches the caller with that vertex in no bag.
eliminate_sampled_fill_basedrecords the bag as soon as it is read, before the elimination and before any deadline check in the repair. One statement moved.build_tdrank assertion in a debug build and failsvalidatewith "vertex 509 is in no bag" in a release build (2,000-vertex chorded ring).Ten-second table, 9,413 graphs, both rows measured on the same boxes:
Co-Authored-By: Claude Fable 5.1 noreply@anthropic.com