Skip to content

Fix testfindRowAsString ObjectNotFoundException on empty database #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rvosa merged 2 commits into from
Dec 21, 2025
Merged

Fix testfindRowAsString ObjectNotFoundException on empty database #304

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d43a08e
Initial plan
Copilot Dec 21, 2025
57775c9
Fix testfindRowAsString to handle empty database
Copilot Dec 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions treebase-core/src/test/java/org/cipres/treebase/dao/matrix/MatrixDAOTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,17 +146,24 @@ public void testfindRowAsString() {
logger.info("\n\t\tRunning Test: " + testName);
}

// 1.find a submission with matrix:
// 1. Check if matrix exists in database:
Long matrixId = 265L; //
//Long matrixId = 1544L; // 40k+ columns!
//Long matrixId = 1547L; // large, but not crazy.
CharacterMatrix m = (CharacterMatrix) loadObject(CharacterMatrix.class, matrixId);

if (m != null) {
String matrixSQL = "select matrix_id from matrix where matrix_id = " + matrixId + " fetch first rows only";
List<Long> result = jdbcTemplate.queryForList(matrixSQL, Long.class);

// 2. verify correct handling of empty database
assertNotNull("Query should return non-null list", result);

if (result != null && !result.isEmpty()) {
CharacterMatrix m = (CharacterMatrix) loadObject(CharacterMatrix.class, matrixId);

int start = 0;
int end = 30;

//2. query:
//3. query:
List<String> rowStrings = getFixture().findRowAsString(m, start, end);

if (logger.isInfoEnabled()) {
Expand All @@ -171,7 +178,7 @@ public void testfindRowAsString() {

//assertTrue(rowStrings.size() == (end-start + 1));

// 3. verify
// 4. verify
//String matrixSQL = "select count(*) from matrix where matrix_id = " + m.getId();
//int count = jdbcTemplate.queryForInt(matrixSQL);
//assertTrue(count == 1);
Expand Down
Loading