Fix lazy loading issue in test base class causing spurious test failures

[Copilot]

Tests using AbstractDAOTest.loadObject() were failing with uncaught ObjectNotFoundException when database entities didn't exist, instead of gracefully skipping as intended.

Changes

• Changed AbstractDAOTest.loadObject() to use hibernateTemplate.get() instead of hibernateTemplate.load()
• Method now returns null immediately when entities don't exist, preventing lazy loading exceptions

Technical Details

Hibernate's hibernateTemplate.load() returns a lazy proxy object even when an entity doesn't exist in the database. The ObjectNotFoundException is only thrown later when properties are accessed on this proxy, not during the load() call itself. This caused exceptions to occur in test code rather than being handled in loadObject().

The solution uses hibernateTemplate.get() instead, which:

• Immediately queries the database
• Returns null if the entity doesn't exist (no proxy created)
• Prevents ObjectNotFoundException from being thrown later in test code

public TBPersistable loadObject(Class pClass, Long pID) {
    TBPersistable obj = null;
    try {
        obj = (TBPersistable) hibernateTemplate.get(pClass, pID);  // Changed from load() to get()
    } catch (DataAccessException ex) {
        obj = null;
    }
    return obj;
}

All affected tests already check for null and skip with "empty database, test skipped" messages - they just needed the entity loading to return null instead of a proxy that throws exceptions.

Impact

Fixes 6 failing tests that expect entities with specific IDs (Matrix #265, #683, Study #794, #586). Applies to all 40 test classes extending AbstractDAOTest.

Original prompt

Numerous unit tests are failing in the same way. Implement a generalized way to address this. If the row doesn't exist, it must mean that we're testing against an empty database, in which case the test is skipped with an informational message. Otherwise proceed with the test as intended.

org.cipres.treebase.domain.matrix.MatrixTest ► testGetFormatInfo: treebase-core/src/test/java/org/cipres/treebase/domain/matrix/MatrixTest.java#L40
Failed test found in:
  treebase-core/target/surefire-reports/TEST-org.cipres.treebase.domain.matrix.MatrixTest.xml
Error:
  org.hibernate.ObjectNotFoundException: No row with the given identifier exists: [org.cipres.treebase.domain.matrix.Matrix#265]
---
org.cipres.treebase.domain.matrix.MatrixTest ► testGenerateNexusBlock: treebase-core/src/test/java/org/cipres/treebase/domain/matrix/MatrixTest.java#L71
Failed test found in:
  treebase-core/target/surefire-reports/TEST-org.cipres.treebase.domain.matrix.MatrixTest.xml
Error:
  org.hibernate.ObjectNotFoundException: No row with the given identifier exists: [org.cipres.treebase.domain.matrix.Matrix#683]
---
org.cipres.treebase.domain.nexus.NexmlAnalysisConverterTest ► testNexmlAnalysisConverter: treebase-core/src/main/java/org/cipres/treebase/domain/nexus/nexml/NexmlObjectConverter.java#L45
Failed test found in:
  treebase-core/target/surefire-reports/TEST-org.cipres.treebase.domain.nexus.NexmlAnalysisConverterTest.xml
Error:
  org.hibernate.ObjectNotFoundException: No row with the given identifier exists: [org.cipres.treebase.domain.study.Study#794]    
---
org.cipres.treebase.domain.nexus.NexmlMatrixConverterTest ► testNexmlMatrixConverter: treebase-core/src/test/java/org/cipres/treebase/domain/nexus/NexmlMatrixConverterTest.java#L54
Failed test found in:
  treebase-core/target/surefire-reports/TEST-org.cipres.treebase.domain.nexus.NexmlMatrixConverterTest.xml
Error:
  org.hibernate.ObjectNotFoundException: No row with the given identifier exists: [org.cipres.treebase.domain.study.Study#794]
---
org.cipres.treebase.domain.nexus.NexmlMatrixConverterTest ► testNexmlEmptyMatrix: treebase-core/src/test/java/org/cipres/treebase/domain/nexus/NexmlMatrixConverterTest.java#L166
Failed test found in:
  treebase-core/target/surefire-reports/TEST-org.cipres.treebase.domain.nexus.NexmlMatrixConverterTest.xml
Error:
  org.hibernate.ObjectNotFoundException: No row with the given identifier exists: [org.cipres.treebase.domain.study.Study#586]
---
org.cipres.treebase.domain.nexus.NexmlMatrixConverterTest ► testNexmlMatrixCharSets: treebase-core/src/test/java/org/cipres/treebase/domain/nexus/NexmlMatrixConverterTest.java#L269
Failed test found in:
  treebase-core/target/surefire-reports/TEST-org.cipres.treebase.domain.nexus.NexmlMatrixConverterTest.xml
Error:
  org.hibernate.ObjectNotFoundException: No row with the given identifier exists: [org.cipres.treebase.domain.study.Study#794]        

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[rvosa]

@copilot we're still getting these failures:

org.cipres.treebase.domain.matrix.MatrixTest ► testGetFormatInfo: treebase-core/src/test/java/org/cipres/treebase/domain/matrix/MatrixTest.java#L40
Failed test found in:
  treebase-core/target/surefire-reports/TEST-org.cipres.treebase.domain.matrix.MatrixTest.xml
Error:
  org.hibernate.ObjectNotFoundException: No row with the given identifier exists: [org.cipres.treebase.domain.matrix.Matrix#265]

org.cipres.treebase.domain.matrix.MatrixTest ► testGenerateNexusBlock: treebase-core/src/test/java/org/cipres/treebase/domain/matrix/MatrixTest.java#L71
Failed test found in:
  treebase-core/target/surefire-reports/TEST-org.cipres.treebase.domain.matrix.MatrixTest.xml
Error:
  org.hibernate.ObjectNotFoundException: No row with the given identifier exists: [org.cipres.treebase.domain.matrix.Matrix#683]

org.cipres.treebase.domain.nexus.NexmlAnalysisConverterTest ► testNexmlAnalysisConverter: treebase-core/src/main/java/org/cipres/treebase/domain/nexus/nexml/NexmlObjectConverter.java#L45
Failed test found in:
  treebase-core/target/surefire-reports/TEST-org.cipres.treebase.domain.nexus.NexmlAnalysisConverterTest.xml
Error:
  org.hibernate.ObjectNotFoundException: No row with the given identifier exists: [org.cipres.treebase.domain.study.Study#794]

org.cipres.treebase.domain.nexus.NexmlMatrixConverterTest ► testNexmlMatrixConverter: treebase-core/src/test/java/org/cipres/treebase/domain/nexus/NexmlMatrixConverterTest.java#L54
Failed test found in:
  treebase-core/target/surefire-reports/TEST-org.cipres.treebase.domain.nexus.NexmlMatrixConverterTest.xml
Error:
  org.hibernate.ObjectNotFoundException: No row with the given identifier exists: [org.cipres.treebase.domain.study.Study#794]

org.cipres.treebase.domain.nexus.NexmlMatrixConverterTest ► testNexmlEmptyMatrix: treebase-core/src/test/java/org/cipres/treebase/domain/nexus/NexmlMatrixConverterTest.java#L166
Failed test found in:
  treebase-core/target/surefire-reports/TEST-org.cipres.treebase.domain.nexus.NexmlMatrixConverterTest.xml
Error:
  org.hibernate.ObjectNotFoundException: No row with the given identifier exists: [org.cipres.treebase.domain.study.Study#586]

org.cipres.treebase.domain.nexus.NexmlMatrixConverterTest ► testNexmlMatrixCharSets: treebase-core/src/test/java/org/cipres/treebase/domain/nexus/NexmlMatrixConverterTest.java#L269
Failed test found in:
  treebase-core/target/surefire-reports/TEST-org.cipres.treebase.domain.nexus.NexmlMatrixConverterTest.xml
Error:
  org.hibernate.ObjectNotFoundException: No row with the given identifier exists: [org.cipres.treebase.domain.study.Study#794]

[Copilot]

@copilot we're still getting these failures:

...

Fixed in commit 1e1e8f1. The issue was that hibernateTemplate.load() returns a lazy proxy object that doesn't throw ObjectNotFoundException until you access its properties. Changed to use hibernateTemplate.get() instead, which immediately queries the database and returns null if the entity doesn't exist, preventing the exception from occurring later in test code.