feat: check for custom root in config on dashboard index#360
Open
Tao-Galasse wants to merge 1 commit into
Open
feat: check for custom root in config on dashboard index#360Tao-Galasse wants to merge 1 commit into
Tao-Galasse wants to merge 1 commit into
Conversation
Tao-Galasse
force-pushed
the
dashboard-index-root
branch
from
3808ef8 to
4030f7c
Compare
Tao-Galasse
force-pushed
the
dashboard-index-root
branch
from
4030f7c to
94c7a46
Compare
yhru
approved these changes
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @spohlenz !
Here is a little POC to fix a recent issue which I think should be improved. It's probably not the cleanest way to do it, but I wanted to provide an example of how we could find a solution.
Currently, Trestle do not use the value set in
config.rootas the default redirected route of the application.For example, if you defined a root which is not the one with the highest priority, it will be used as the "home" in the breadcrumb, but will not be the view displayed when accessing the base URL of the back office.
IMHO, those two values should be the same, what is defined as the "root" should be the default view.
Do you have any opinion about this ?