Use Buffer.from() instead of new Buffer() - #113
Open
matiasleva wants to merge 2 commits into
Open
Conversation
Avoid deprecation warning in nodejs12.x
kusor
self-requested a review
April 28, 2020 10:32
kusor
suggested changes
Apr 28, 2020
kusor
left a comment
kusor
left a comment
Contributor
There was a problem hiding this comment.
If I'm not on a mistake, this method has been added since version 4.x of node. I'd say that in order to merge this pull request, package.json should be modified to explicitly require a version of node greater or equal than 4.9.x.
And given than the node dependency will be modified, I'd also bump package version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid deprecation warning in nodejs12.x