Skip to content

feat(security): unblock public CA cluster deployments#446

Merged
yordis merged 2 commits into
masterfrom
yordis/feat-certificate-eku-policy
Jul 19, 2026
Merged

feat(security): unblock public CA cluster deployments#446
yordis merged 2 commits into
masterfrom
yordis/feat-certificate-eku-policy

Conversation

@yordis

@yordis yordis commented Jul 19, 2026

Copy link
Copy Markdown
Member
  • Managed certificate authorities may omit the Client Authentication usage, preventing secure nodes from authenticating during cluster operations.
  • Strict validation should remain the default so operators make this compatibility decision explicitly.
  • Kubernetes deployments need a supported path for externally managed node certificates without weakening trust or node identity checks.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@cursor

cursor Bot commented Jul 19, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes cluster node identity checks for HTTPS when operators opt in; default remains strict, but misconfiguration could weaken mutual TLS expectations for inter-node HTTP.

Overview
Adds explicit compatibility for public-CA node certificates that include Server Authentication but not Client Authentication in the Extended Key Usage extension—common when the same cert is used for node-to-node HTTPS.

New configuration AllowNodeCertificateWithoutClientAuthEku (CLI, YAML, EVENTSTORE_ALLOW_NODE_CERTIFICATE_WITHOUT_CLIENT_AUTH_EKU) defaults to false. When enabled, IsServerCertificate can treat server-auth-only certs as valid node server certs; NodeCertificateAuthenticationProvider applies the policy for incoming HTTPS cluster connections. Reserved node CN, SAN, chain, and Server Authentication requirements are unchanged, and user certificate authentication is not relaxed. The flag is read via a reloadable delegate from ClusterVNode (including SIGHUP config reload).

Documentation in docs/security.md describes when to enable this and notes it does not affect legacy secure TCP replication certificate handling.

Reviewed by Cursor Bugbot for commit ded7510. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@yordis, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 4 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4c3ceabe-84c8-4e0c-9069-2d6bbf0035e1

📥 Commits

Reviewing files that changed from the base of the PR and between d9af4ae and ded7510.

📒 Files selected for processing (8)
  • docs/security.md
  • src/EventStore.Common/Utils/CertificateExtensions.cs
  • src/EventStore.Core.Tests/Certificates/key_usages.cs
  • src/EventStore.Core.Tests/Services/Transport/Http/Authentication/node_certificate_authentication_provider.cs
  • src/EventStore.Core.XUnit.Tests/Configuration/ClusterVNodeOptionsTests.cs
  • src/EventStore.Core/ClusterVNode.cs
  • src/EventStore.Core/Configuration/ClusterVNodeOptions.cs
  • src/EventStore.Core/Services/Transport/Http/Authentication/NodeCertificateAuthenticationProvider.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yordis/feat-certificate-eku-policy

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread src/EventStore.Core/ClusterVNode.cs Outdated
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ded7510. Configure here.

@yordis
yordis merged commit ea39969 into master Jul 19, 2026
22 checks passed
@yordis
yordis deleted the yordis/feat-certificate-eku-policy branch July 19, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant