Repository navigation
chore: enhance reset batch event handler test to verify account clearance after reset - #21
Conversation
|
Warning Rate limit exceeded@yordis has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 12 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughAdds synchronization to the reset-batch test: preload events, start handler with start_from: :current, send a :reset, wait for the handler to process reset (verifying it stays alive and current accounts become empty), then append a new event and verify processing. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant T as Test
participant H as BankAccountBatchHandler
participant E as EventStore
T->>E: Preload initial events (before start)
T->>H: Start handler (start_from: :current)
note right of H: Should ignore preloaded events
T->>H: Send :reset
H->>H: Resubscribe / clear state
T->>H: Monitor + poll current_accounts()
H-->>T: [] /* Test proceeds when empty */
T->>E: Append new event
E-->>H: Deliver new event
H-->>T: Processed (observed by test)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
test/event/reset_batch_event_handler_test.exs (1)
58-63: Solid sync point; pass an explicit timeout to avoid hanging testsNice addition. Minor: ensure
Wait.until/1actually exists; the helper snippet showsuntil(timeout, fun)and, if no base case, can recurse forever. Passing an explicit timeout keeps the test bounded and consistent.Proposed tweak:
- Wait.until(fn -> + Wait.until(2_000, fn -> assert BankAccountBatchHandler.current_accounts() == [] end)If flakiness persists, consider a stronger barrier than re-checking
[](which was already true pre-reset), e.g., waiting on an exposed restart/subscription counter if available.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
test/event/reset_batch_event_handler_test.exs(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
test/event/reset_batch_event_handler_test.exs (1)
test/helpers/wait.ex (1)
until(8-16)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Quality Assurance (1.18.x, 27)
b7358b8 to
c33ea94
Compare
…ance after reset Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
No description provided.